Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltfio: do not set clear coat in GLTFIO_LITE config. #4156

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

prideout
Copy link
Contributor

This avoids an assertion in debug builds. We will document this behavior
much more thoroughly in a subsequent PR.

Fixes #4143.

@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@prideout prideout requested a review from romainguy June 17, 2021 20:28
@prideout
Copy link
Contributor Author

btw Romain we actually do support UNLIT in lite mode, despite what I said earlier.

This avoids an assertion in debug builds. We will document this behavior
much more thoroughly in a subsequent PR.

Fixes #4143.
@prideout prideout merged commit 7843085 into main Jun 17, 2021
@prideout prideout deleted the pr/lite branch June 17, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use libgltfio_resources_lite.a library to crash in hello-gltf
3 participants