Reduce verification code save to 2 SQL statements. #360

mikehelmick · 2020-08-25T16:37:47Z

Fixes #359

Proposed Changes

Change foreign key to be just the ID and not the relationship on verification codes, reduce SQL overhead when saving verification code records.

Release Note

Optimized SQL for issuing verification codes.

sethvargo

/lgtm
/approve

google-oss-robot · 2020-08-25T16:40:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Reduce verification code save to 2 SQL statements.

2c8bcf5

google-oss-robot requested review from icco and whaught August 25, 2020 16:37

google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Aug 25, 2020

google-oss-robot added approved labels Aug 25, 2020

sethvargo approved these changes Aug 25, 2020

View reviewed changes

google-oss-robot assigned sethvargo Aug 25, 2020

google-oss-robot added the lgtm label Aug 25, 2020

google-oss-robot merged commit 276a7d3 into google:main Aug 25, 2020

google locked and limited conversation to collaborators Oct 6, 2020