Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

fix content-type on return and a stray 200 code #275

Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix content-type on return and a stray 200 code #275

merged 1 commit into from
Aug 19, 2020

Conversation

mikehelmick
Copy link
Contributor

Proposed Changes

  • set correct content-type return header
  • one case where error was returning 200

Release Note

Proper content-type set on all HTTP responses.

@mikehelmick mikehelmick requested a review from sethvargo August 19, 2020 04:03
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Aug 19, 2020
@icco
Copy link
Contributor

icco commented Aug 19, 2020

/lgtm

@google-oss-robot google-oss-robot merged commit 667292b into google:main Aug 19, 2020
@mikehelmick mikehelmick deleted the rtncode branch August 19, 2020 19:29
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo Awaiting requested review from sethvargo

@icco icco Awaiting requested review from icco

@whaught whaught Awaiting requested review from whaught

Assignees

@icco icco

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehelmick @google-oss-robot @icco