This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Fixes found while spinning up a new project #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mikehelmick
approved these changes
Aug 18, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: icco, mikehelmick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sethvargo
reviewed
Aug 18, 2020
| @@ -60,5 +60,5 @@ fi | |||
|
|
|||
| gcloud builds submit "${ROOT}" \ | |||
| --config "${ROOT}/builders/migrate.yaml" \ | |||
| --substitutions "_DB_CONN=${DB_CONN},_DB_APIKEY_DATABASE_KEY=${DB_APIKEY_DATABASE_KEY},_DB_APIKEY_SIGNATURE_KEY=${DB_APIKEY_SIGNATURE_KEY},_DB_ENCRYPTION_KEY=${DB_ENCRYPTION_KEY},_DB_NAME=${DB_NAME},_DB_PASSWORD=${DB_PASSWORD},_DB_USER=${DB_USER}" \ | |||
| --substitutions "_DB_CONN=${DB_CONN},_DB_APIKEY_DATABASE_KEY=${DB_APIKEY_DATABASE_KEY},_DB_APIKEY_SIGNATURE_KEY=${DB_APIKEY_SIGNATURE_KEY},_DB_ENCRYPTION_KEY=${DB_ENCRYPTION_KEY},_DB_NAME=${DB_NAME},_DB_PASSWORD=${DB_PASSWORD},_DB_USER=${DB_USER},_DB_DEBUG=${DB_DEBUG},_LOG_DEBUG=${LOG_DEBUG}" \ | |||
There was a problem hiding this comment.
I really wish Cloud Build let you specify --substitutions multiple times to avoid this insanely long line...
| @@ -233,14 +233,18 @@ resource "null_resource" "migrate" { | |||
| DB_CONN = google_sql_database_instance.db-inst.connection_name | |||
| DB_ENCRYPTION_KEY = google_kms_crypto_key.database-encrypter.self_link | |||
| DB_NAME = google_sql_database.db.name | |||
| DB_PASSWORD = google_secret_manager_secret_version.db-secret-version["password"].name | |||
| DB_PASSWORD = "secret://${google_secret_manager_secret_version.db-secret-version["password"].id}" | |||
There was a problem hiding this comment.
Hmmmmmm.... this change is correct, but how did it work before?
There was a problem hiding this comment.
That was puzzling me too. But it was late and I was all shrugs. Maybe no one has run this step in a long time?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
secret://Release Note