legacy signing fixes #1624
legacy signing fixes #1624
Conversation
googlebot
added
the
cla: yes
| @@ -95,8 +95,9 @@ func (c *Controller) validateToken(ctx context.Context, verToken string) (string | |||
| return nil, fmt.Errorf("no key corresponds to kid %q", kid) | |||
| } | |||
| tokenSigningKey = &database.TokenSigningKey{KeyVersionID: keyID} | |||
| } else { | |||
| return nil, fmt.Errorf("failed to lookup token signing key: %w", err) | |||
There was a problem hiding this comment.
this was the bug - it filled in legacy key ID, but then returned an error.
| @@ -41,6 +42,9 @@ func main() { | |||
|
|
|||
| ctx, done := signalcontext.OnInterrupt() | |||
|
|
|||
| if os.Getenv("LOG_LEVEL") == "" { | |||
There was a problem hiding this comment.
It’d be better just to use the debugger logger instead of setting the env. Just don’t use logging.NewFromEnv and use the NewDebug method (I think there’s one)
There was a problem hiding this comment.
this still allows the user to specify
meaning remove the flag? |
|
Yea, I think we just always fallback in this release. |
done. Always on in this release. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1623
Proposed Changes
Release Note