DB model for storing key server stats #1599
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
whaught
changed the title
| RequestsMissingOnsetDate int64 `gorm:"column:request_missing_onset_date; type:bigint; not null; default: 0;"` | ||
| } | ||
|
|
||
| func (db *Database) GetKeyServerStats(realmID uint) (*KeyServerStats, error) { |
There was a problem hiding this comment.
This should probably hang off the realm instead:
func (r *Realm) KeyServerStats(db *Database) ... {
}There was a problem hiding this comment.
yea but then you need to have actually loaded the realm which may not be the case
| <label for="allow-bulk-true" class="form-check-label"> | ||
| Enable key-server statistics | ||
| <small class="form-text text-muted mb-3"> | ||
| Checking this box will allow this realm to collect statistics from the key-server about codes |
There was a problem hiding this comment.
there needs to be a note here about how this may need to be disclosed your applications privacy policy.
we should also describe what's here -onset to upload, uploads by operating system.
| @@ -55,6 +56,41 @@ | |||
| </small> | |||
| </div> | |||
|
|
|||
| <hr> | |||
There was a problem hiding this comment.
let's flag disable this until the visualizations are ready
|
/lgtm |
|
/unhold Will follow up with comments |
Issue #1512
Proposed Changes
Release Note