Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Skip conflict and already succeeded lines of csv retries #1530

Merged
merged 5 commits into from
Jan 7, 2021

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jan 7, 2021

Proposed Changes

  • Show the error and line if we skip an entry with < 2 items or no phone number
  • Skip reuploading conflicts (which will conflict again) and successes (which will now conflict). The user can still do so if they clear the error code, but if re-using the log CSV which keeps error columns we want to skip those. This will also make correcting errors and re-uploading faster.

Release Note

The bulk-uploader will skip conflict or already-succeeded lines when re-using a log csv from a previous attempt

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 7, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 10b54be into google:main Jan 7, 2021
@whaught whaught deleted the bulk-parse-errors branch January 8, 2021 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants