-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer Docsy as a single Hugo Module #1217
Conversation
Netlify preview fails, but this was expected. |
Done.
Great. I can contribute to the documentation and will assist in case of any questions/issues. |
7b94b7d
to
b08e422
Compare
de13647
to
4d86311
Compare
0c0a035
to
5d3bfac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deining - Shouldn't github.com/google/docsy/dependencies
entries be removed from go.mod
and go.sum
?
Also running hugo mod tidy
would be a good idea as well, no?
Thanks for the updates. Have you tested this locally, and if so how? I can't get it to work, whether with using a (slightly modified) version of |
You are welcome.
Yes.
I started a new site from scratch, created a clone of docsy beside the newly created site repo and used
I prepared a branch for you on my fork of the docsy-example repo. Please try this:
This works for me out of the box. Can you please give this a try? |
Yes, it works, thanks! I also got it to work with a |
Great to hear that! Do you deem this PR production ready and ready for subsequent merging? |
Almost there! I'd like to address #1217 (comment) first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
In case you missed my nested comment @deining:
|
No I didn't miss it!
Find out your cache dir (on my Unix system, this is
Have a look there, directories you should possibly look at:
and maybe also
|
This PR merges the module
docsy
anddocsy/dependencies
into one single module in order to streamline use of Docsy for Hugo Module users. This is a first take at #1120.