Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-TW: Translate async.md and async/async-await.md #765

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

wdzeng
Copy link
Contributor

@wdzeng wdzeng commented Jun 3, 2023

Part of #684.

@google-cla
Copy link

google-cla bot commented Jun 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mingyc
mingyc previously requested changes Jun 9, 2023
Copy link
Collaborator

@mingyc mingyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits

@wdzeng wdzeng force-pushed the zh-tw branch 2 times, most recently from e0c3994 to 3201f24 Compare June 9, 2023 10:07
@wdzeng
Copy link
Contributor Author

wdzeng commented Jun 9, 2023

Thanks for the review. All comments are fixed.

@wdzeng wdzeng force-pushed the zh-tw branch 3 times, most recently from 781ed5d to 447588b Compare June 9, 2023 10:14
@mgeisler
Copy link
Collaborator

I applied the changes suggested by @hueich. Does this look okay to merge now?

@mgeisler mgeisler dismissed mingyc’s stale review August 17, 2023 08:15

Changes have been applied

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested by @mingyc and @hueich have been applied, so it should be good to go.

@mgeisler mgeisler merged commit 8190fd2 into google:main Aug 17, 2023
@jiyongp jiyongp mentioned this pull request Aug 24, 2023
yohcop pushed a commit to yohcop/comprehensive-rust that referenced this pull request Sep 12, 2023
Part of google#684.

---------

Co-authored-by: Martin Geisler <[email protected]>
Co-authored-by: Addison Luh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants