-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh-TW: Translate async.md and async/async-await.md #765
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
e0c3994
to
3201f24
Compare
Thanks for the review. All comments are fixed. |
781ed5d
to
447588b
Compare
Co-authored-by: Addison Luh <[email protected]>
I applied the changes suggested by @hueich. Does this look okay to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of google#684. --------- Co-authored-by: Martin Geisler <[email protected]> Co-authored-by: Addison Luh <[email protected]>
Part of #684.