Rename zh-Hant.po to zh-TW.po and add CODEOWNER #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mingyc
commented
Jun 2, 2023
mingyc
commented
- Add myself as the code reviewer for zh-TW, as I am already listed in the sheet for zh-Hant translation
- As mentioned in Chinese (Traditional) translation #684 (comment), Traditional Chinese are used differently in HK and TW. The intention for zh-Hant.go was to cover zh-TW.
- Add myself as the code reviewer for zh-TW, as I am already listed in [the sheet](https://docs.google.com/spreadsheets/d/1bVSJEUGkI9gcqmmA4va4y-I7LzgQUqNwnZYJsQNMBGE/edit#gid=0) for zh-Hant translation - As mentioned in google#684 (comment), Traditional Chinese are used differently in HK and TW. The intention for zh-Hant.go was to cover zh-TW.
mingyc
requested review from
edong,
hueich,
kuanhungchen and
victorhsieh
as code owners
mgeisler
approved these changes
Jun 2, 2023
NoahDragon
pushed a commit
to wnghl/comprehensive-rust
that referenced
this pull request
Jul 19, 2023
- Add myself as the code reviewer for zh-TW, as I am already listed in [the sheet](https://docs.google.com/spreadsheets/d/1bVSJEUGkI9gcqmmA4va4y-I7LzgQUqNwnZYJsQNMBGE/edit#gid=0) for zh-Hant translation - As mentioned in google#684 (comment), Traditional Chinese are used differently in HK and TW. The intention for zh-Hant.go was to cover zh-TW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.