Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bn: Add Bengali file with ~150 translations #662

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

raselmandol
Copy link
Contributor

@raselmandol raselmandol commented May 23, 2023

Added Bengali translation (bn.po) file

First part of #653.

Added Bengali translation (bn.po) file
@raselmandol raselmandol requested a review from mirwasi as a code owner May 23, 2023 14:34
@google-cla
Copy link

google-cla bot commented May 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mgeisler mgeisler changed the title Add files via upload bn: Add Bengali translation file with a few translations May 23, 2023
@mgeisler mgeisler changed the title bn: Add Bengali translation file with a few translations bn: Add Bengali file with a few translations May 23, 2023
@mgeisler mgeisler changed the title bn: Add Bengali file with a few translations bn: Add Bengali file with ~150 translations May 23, 2023
@mgeisler
Copy link
Collaborator

Awesome, thanks @raselmandol! The rendered course can now be found as a build artifact on the bottom of this page: https://github.com/google/comprehensive-rust/actions/runs/5058634906

Copy link
Collaborator

@mirwasi mirwasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raselmandol for your contribution! I'm approving your pull request.

@mirwasi
Copy link
Collaborator

mirwasi commented May 24, 2023

@raselmandol: The Contributor License Agreement (CLA) check is failing. Could you please sign the contributor CLA as per https://github.com/google/comprehensive-rust/blob/main/CONTRIBUTING.md#contributor-license-agreement?

@raselmandol
Copy link
Contributor Author

@mirwasi , I have signed the contributor CLA now, could you please check again?

@mirwasi mirwasi merged commit d73de18 into google:main May 24, 2023
@mirwasi
Copy link
Collaborator

mirwasi commented May 24, 2023

All good now, thanks!

momotaro1105 pushed a commit to CoinEZ-JPN/comprehensive-rust that referenced this pull request May 25, 2023
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants