Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AIDL intermediates path #2639

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

randomPoison
Copy link
Collaborator

The path to the generated Rust code for AIDL definitions seems to have changed, this updates the slide to reflect the current location. This also assumes that the CompRust repo is checked out at the root of an AOSP checkout.

@mgeisler
Copy link
Collaborator

This also assumes that the CompRust repo is checked out at the root of an AOSP checkout.

Yeah, I left that part out in the ... — since the path is long and ugly, I figured we should not try to show it in full.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the path — my instinct would be show as little as possible.

When teaching this, I've used fd IBirthdayService.rs soong/.intermediates a few times to quickly find the file. That is basically why the path is shown (plus to be consistent with the other code blocks that show file content).

@randomPoison randomPoison enabled auto-merge (squash) February 26, 2025 17:19
@randomPoison randomPoison merged commit d7a8821 into main Feb 26, 2025
37 checks passed
@randomPoison randomPoison deleted the legare/update-intermediates-path branch February 26, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants