Clarify struct-lifetimes slide #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In teaching the course, the verbal distinction between "doc" and "dog" was not clear, so this PR moves away from those symbols. This also makes the Highlight struct a little more substantial, and replaces `erase` with a simple call to `drop` to keep the example short.
|
I would suggest |
hurryabit
approved these changes
Jan 23, 2025
djmitche
added a commit
that referenced
this pull request
Jan 23, 2025
This helps clarify that the lifetime and variables names do not need to match, but sticks to related themes (doc / document) for human clarity. As suggested by @fw-immunant in #2585 (review), which subsequently auto-merged.
michael-kerscher
pushed a commit
to michael-kerscher/comprehensive-rust
that referenced
this pull request
Feb 7, 2025
In teaching the course, the verbal distinction between "doc" and "dog" was not clear, so this PR moves away from those symbols. This also makes the Highlight struct a little more substantial, and replaces `erase` with a simple call to `drop` to keep the example short.
michael-kerscher
pushed a commit
to michael-kerscher/comprehensive-rust
that referenced
this pull request
Feb 7, 2025
This helps clarify that the lifetime and variables names do not need to match, but sticks to related themes (doc / document) for human clarity. As suggested by @fw-immunant in google#2585 (review), which subsequently auto-merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In teaching the course, the verbal distinction between "doc" and "dog" was not clear, so this PR moves away from those symbols.
This also makes the Highlight struct a little more substantial, and replaces
erasewith a simple call todropto keep the example short.