Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Execution: Add stderr block" #2479

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Revert "Execution: Add stderr block" #2479

merged 1 commit into from
Nov 28, 2024

Conversation

mgeisler
Copy link
Collaborator

Reverts #2397

I'm seeing

POST https://play.rust-lang.org/execute 500 (Internal Server Error)

on every request when trying to run code in the Playground. I'm not sure why, but we need to revert this ASAP if others see the same.

@mgeisler mgeisler requested review from djmitche and qwandor November 28, 2024 14:59
@mgeisler
Copy link
Collaborator Author

@michael-kerscher, another reason why we need to merge and start using your unit testing code 😄

@mgeisler mgeisler merged commit 7d2bde6 into main Nov 28, 2024
37 checks passed
@mgeisler mgeisler deleted the revert-2397-main branch November 28, 2024 15:40
@mgeisler
Copy link
Collaborator Author

mgeisler commented Dec 6, 2024

@michael-kerscher, another reason why we need to merge and start using your unit testing code 😄

Actually, I now think we ran into a Playground incident where the Playground was slow for everyone.

I would like to get @Alx-Lai's change back in, so I'll set up a revert for this.

mgeisler added a commit that referenced this pull request Dec 6, 2024
mgeisler added a commit that referenced this pull request Dec 6, 2024
Reverts #2479, which is a revert of #2397.

I think the problem was not related to @Alx-Lai's change, the
[Playground was
slow](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/playground.20incident.202024-12-03)
for everyone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants