Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move const before static #2305

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

tomfitzhenry
Copy link
Contributor

Motivation:

  • const usecases are likely more familiar than static usecases
  • currently the static slide refers const, before it's introduced

Background: static and const were previously on the same slide, with const being introduced first (
#1881 ) but when they were split, static was moved first.

Motivation:
* const usecases are likely more familiar than static usecases
* currently the static slide refers `const`, before it's introduced

Background: static and const were previously on the same slide, with const being
introduced first (
#1881 ) but when they
were split, static was moved first.
Copy link
Collaborator

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this makes more sense than the other order. Thanks!

@djmitche djmitche enabled auto-merge (squash) August 23, 2024 18:42
@djmitche djmitche merged commit 26979c9 into google:main Aug 23, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants