Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko: Refreshes .po file #1921

Merged
merged 1 commit into from
Mar 15, 2024
Merged

ko: Refreshes .po file #1921

merged 1 commit into from
Mar 15, 2024

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Mar 14, 2024 •
edited
Loading

This is a clean refresh, requires only a syntactic review.

You can skim this PR with the GitHub CLI:

gh pr diff 1921 | bat -l patch

#262

@henrif75 henrif75 requested a review from mgeisler March 14, 2024 14:57
@henrif75 henrif75 marked this pull request as ready for review March 14, 2024 14:57
jiyongp
jiyongp approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@jiyongp jiyongp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Most were dropping the line numbers from the source md file location.

I wanted to remove some fuzzy markers (because the translations looked okay), but didn't do that.

@henrif75
Copy link
Collaborator Author

LGTM. Most were dropping the line numbers from the source md file location.

I wanted to remove some fuzzy markers (because the translations looked okay), but didn't do that.

Thanks @jiyongp !
It's ok, I'm going to merge this PR and I think you can send a separate one to clean some of the fuzzy.

@henrif75 henrif75 merged commit b4be1d0 into google:main Mar 15, 2024
33 checks passed
@henrif75 henrif75 deleted the ko-refresh branch March 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyongp jiyongp jiyongp approved these changes

@mgeisler mgeisler Awaiting requested review from mgeisler

@jooyunghan jooyunghan Awaiting requested review from jooyunghan jooyunghan is a code owner

@namhyung namhyung Awaiting requested review from namhyung namhyung is a code owner

Assignees
No one assigned
Labels
translation/ko translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrif75 @jiyongp