RELNOTES[INC]: RecordFunction now runs in strict mode.

PiperOrigin-RevId: 333781698

closure/goog/async/run_next_tick_test.js

@@ -137,7 +137,7 @@ testSuite({
     // and get the correct scope.
     const last1 = futureCallback1.popLastCall();
     assertEquals(0, last1.getArguments().length);
-    assertEquals(goog.global, last1.getThis());
+    assertEquals(undefined, last1.getThis());
 
     const last2 = futureCallback2.popLastCall();
     assertEquals(0, last2.getArguments().length);

closure/goog/async/run_test.js

@@ -156,7 +156,7 @@ testSuite({
         // and get the correct scope.
         const last1 = futureCallback1.popLastCall();
         assertEquals(0, last1.getArguments().length);
-        assertEquals(goog.global, last1.getThis());
+        assertEquals(undefined, last1.getThis());
 
         const last2 = futureCallback2.popLastCall();
         assertEquals(0, last2.getArguments().length);

closure/goog/promise/promise_test.js

@@ -1497,7 +1497,7 @@ testSuite({
       assertEquals(1, rejectionCall.getArguments().length);
       const err = rejectionCall.getArguments()[0];
       assertEquals('thenAlways throw', err.message);
-      assertEquals(goog.global, rejectionCall.getThis());
+      assertEquals(null, rejectionCall.getThis());
     });
 
     return p.thenAlways(() => {
@@ -2041,7 +2041,7 @@ testSuite({
     assertEquals(1, unhandledRejections.getCallCount());
     const rejectionCall = unhandledRejections.popLastCall();
     assertArrayEquals([sentinel], rejectionCall.getArguments());
-    assertEquals(goog.global, rejectionCall.getThis());
+    assertEquals(null, rejectionCall.getThis());
   },
 
   testUnhandledRejection2() {
@@ -2052,7 +2052,7 @@ testSuite({
     assertEquals(1, unhandledRejections.getCallCount());
     const rejectionCall = unhandledRejections.popLastCall();
     assertArrayEquals([sentinel], rejectionCall.getArguments());
-    assertEquals(goog.global, rejectionCall.getThis());
+    assertEquals(null, rejectionCall.getThis());
   },
 
   testThenVoidUnhandledRejection() {
@@ -2063,7 +2063,7 @@ testSuite({
     assertEquals(1, unhandledRejections.getCallCount());
     const rejectionCall = unhandledRejections.popLastCall();
     assertArrayEquals([sentinel], rejectionCall.getArguments());
-    assertEquals(goog.global, rejectionCall.getThis());
+    assertEquals(null, rejectionCall.getThis());
   },
 
   testUnhandledRejection() {
@@ -2116,7 +2116,7 @@ testSuite({
     assertEquals(1, unhandledRejections.getCallCount());
     const rejectionCall = unhandledRejections.popLastCall();
     assertArrayEquals([sentinel], rejectionCall.getArguments());
-    assertEquals(goog.global, rejectionCall.getThis());
+    assertEquals(null, rejectionCall.getThis());
   },
 
   testUnhandledRejectionAfterThenAlways() {
@@ -2129,7 +2129,7 @@ testSuite({
     assertEquals(1, unhandledRejections.getCallCount());
     const rejectionCall = unhandledRejections.popLastCall();
     assertArrayEquals([sentinel], rejectionCall.getArguments());
-    assertEquals(goog.global, rejectionCall.getThis());
+    assertEquals(null, rejectionCall.getThis());
   },
 
   testHandledBlockingRejection() {

closure/goog/testing/recordfunction.js

@@ -107,6 +107,7 @@ goog.testing.recordedFunction_.reset = function() {};
  * @return {!goog.testing.recordFunction.Type} The wrapped function.
  */
 goog.testing.recordFunction = function(opt_f) {
+  'use strict';
   var f = opt_f || goog.nullFunction;
   var calls = [];
   /** @type {?goog.promise.Resolver} */
@@ -141,7 +142,10 @@ goog.testing.recordFunction = function(opt_f) {
   /**
    * @return {number} Total number of calls.
    */
-  recordedFunction.getCallCount = function() { return calls.length; };
+  recordedFunction.getCallCount = function() {
+    'use strict';
+    return calls.length;
+  };
 
   /**
    * Asserts that the function was called a certain number of times.
@@ -150,6 +154,7 @@ goog.testing.recordFunction = function(opt_f) {
    * @param {number=} opt_b The expected number of calls (2 args only).
    */
   recordedFunction.assertCallCount = function(a, opt_b) {
+    'use strict';
     var actual = calls.length;
     var expected = arguments.length == 1 ? a : opt_b;
     var message = arguments.length == 1 ? '' : ' ' + a;
@@ -162,14 +167,18 @@ goog.testing.recordFunction = function(opt_f) {
    * @return {!Array<!goog.testing.FunctionCall>} All calls of the recorded
    *     function.
    */
-  recordedFunction.getCalls = function() { return calls; };
+  recordedFunction.getCalls = function() {
+    'use strict';
+    return calls;
+  };
 
 
   /**
    * @return {goog.testing.FunctionCall} Last call of the recorded function or
    *     null if it hasn't been called.
    */
   recordedFunction.getLastCall = function() {
+    'use strict';
     return calls[calls.length - 1] || null;
   };
 
@@ -178,7 +187,10 @@ goog.testing.recordFunction = function(opt_f) {
    * @return {goog.testing.FunctionCall} Last call of the recorded function or
    *     null if it hasn't been called.
    */
-  recordedFunction.popLastCall = function() { return calls.pop() || null; };
+  recordedFunction.popLastCall = function() {
+    'use strict';
+    return calls.pop() || null;
+  };
 
   /**
    * Returns a goog.Promise that resolves when the recorded function has equal
@@ -187,6 +199,7 @@ goog.testing.recordFunction = function(opt_f) {
    * @return {!goog.Promise<undefined>}
    */
   recordedFunction.waitForCalls = function(num) {
+    'use strict';
     waitForCallsCount = num;
     waitForCallsResolver = goog.Promise.withResolver();
     var promise = waitForCallsResolver.promise;
@@ -198,6 +211,7 @@ goog.testing.recordFunction = function(opt_f) {
    * Resets the recorded function and removes all calls.
    */
   recordedFunction.reset = function() {
+    'use strict';
     calls.length = 0;
     waitForCallsResolver = null;
     waitForCallsCount = 0;
@@ -219,6 +233,7 @@ goog.testing.recordFunction.Type;
  * @return {!Function} The wrapped function.
  */
 goog.testing.recordConstructor = function(ctor) {
+  'use strict';
   var recordedConstructor = goog.testing.recordFunction(ctor);
   recordedConstructor.prototype = ctor.prototype;
 
@@ -241,6 +256,7 @@ goog.testing.recordConstructor = function(ctor) {
  * @constructor
  */
 goog.testing.FunctionCall = function(func, thisContext, args, ret, error) {
+  'use strict';
   this.function_ = func;
   this.thisContext_ = thisContext;
   this.arguments_ = Array.prototype.slice.call(args);
@@ -253,6 +269,7 @@ goog.testing.FunctionCall = function(func, thisContext, args, ret, error) {
  * @return {!Function} The called function.
  */
 goog.testing.FunctionCall.prototype.getFunction = function() {
+  'use strict';
   return this.function_;
 };
 
@@ -262,6 +279,7 @@ goog.testing.FunctionCall.prototype.getFunction = function() {
  *     the created object if the function is a constructor.
  */
 goog.testing.FunctionCall.prototype.getThis = function() {
+  'use strict';
   return this.thisContext_;
 };
 
@@ -270,6 +288,7 @@ goog.testing.FunctionCall.prototype.getThis = function() {
  * @return {!Array<?>} Arguments of the called function.
  */
 goog.testing.FunctionCall.prototype.getArguments = function() {
+  'use strict';
   return this.arguments_;
 };
 
@@ -280,6 +299,7 @@ goog.testing.FunctionCall.prototype.getArguments = function() {
  * @return {*} The argument value or undefined if there is no such argument.
  */
 goog.testing.FunctionCall.prototype.getArgument = function(index) {
+  'use strict';
   return this.arguments_[index];
 };
 
@@ -288,6 +308,7 @@ goog.testing.FunctionCall.prototype.getArgument = function(index) {
  * @return {*} Return value of the function or undefined in case of error.
  */
 goog.testing.FunctionCall.prototype.getReturnValue = function() {
+  'use strict';
   return this.returnValue_;
 };
 
@@ -296,5 +317,6 @@ goog.testing.FunctionCall.prototype.getReturnValue = function() {
  * @return {*} The error thrown by the function or null if none.
  */
 goog.testing.FunctionCall.prototype.getError = function() {
+  'use strict';
   return this.error_;
 };

closure/goog/testing/recordfunction_test.js

@@ -34,7 +34,7 @@ testSuite({
     const lastCall = f.getLastCall();
     assertEquals(
         'original function', goog.nullFunction, lastCall.getFunction());
-    assertEquals('this context', window, lastCall.getThis());
+    assertEquals('this context', undefined, lastCall.getThis());
     assertArrayEquals('arguments', [1], lastCall.getArguments());
     assertEquals('arguments[0]', 1, lastCall.getArgument(0));
     assertUndefined('arguments[1]', lastCall.getArgument(1));
@@ -54,7 +54,7 @@ testSuite({
     assertEquals('last call', calls[1], lastCall);
     assertEquals(
         'original function', functions.identity, lastCall.getFunction());
-    assertEquals('this context of first call', window, firstCall.getThis());
+    assertEquals('this context of first call', undefined, firstCall.getThis());
     assertEquals('this context of last call', dummyThis, lastCall.getThis());
     assertArrayEquals(
         'arguments of the first call', [1], firstCall.getArguments());
@@ -76,7 +76,7 @@ testSuite({
     assertEquals('error message', 'error', error.message);
     assertEquals('call count', 1, f.getCallCount());
     const lastCall = f.getLastCall();
-    assertEquals('this context', window, lastCall.getThis());
+    assertEquals('this context', undefined, lastCall.getThis());
     assertArrayEquals('arguments', [1], lastCall.getArguments());
     assertUndefined('return value', lastCall.getReturnValue());
     assertEquals(