Delete deprecated goog.net.cookies.

goog.net.cookies was deprecated and replaced by goog.net.Cookies some time ago. This change finally deletes the definition of goog.net.cookies. RELNOTES: Delete deprecated goog.net.cookies. PiperOrigin-RevId: 432329161 Change-Id: Id7fa33a47d2f2a5d83c918b90faebaa1320b3eea
google · Mar 4, 2022 · 67d06cf · 67d06cf
1 parent b1f2691
commit 67d06cf
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 37 deletions.
diff --git a/closure/goog/net/BUILD b/closure/goog/net/BUILD
@@ -102,7 +102,6 @@ closure_js_library(
     name = "cookies",
     srcs = [
         "cookies.js",
-        "cookies_deprecated.js",
     ],
     lenient = True,
     deps = ["//closure/goog/string"],

diff --git a/closure/goog/net/cookies_deprecated.js b/closure/goog/net/cookies_deprecated.js
diff --git a/closure/goog/net/cookies_test.js b/closure/goog/net/cookies_test.js
@@ -9,11 +9,11 @@ goog.setTestOnly();
 
 const Cookies = goog.require('goog.net.Cookies');
 const PropertyReplacer = goog.require('goog.testing.PropertyReplacer');
-const cookies = goog.require('goog.net.cookies');
 const googArray = goog.require('goog.array');
 const testSuite = goog.require('goog.testing.testSuite');
 
 let baseCount = 0;
+const cookies = Cookies.getInstance();
 const stubs = new PropertyReplacer();
 
 function checkForCookies() {

diff --git a/closure/goog/ui/cookieeditor_test.js b/closure/goog/ui/cookieeditor_test.js
@@ -8,24 +8,15 @@ goog.module('goog.ui.CookieEditorTest');
 goog.setTestOnly();
 
 const CookieEditor = goog.require('goog.ui.CookieEditor');
+const Cookies = goog.require('goog.net.Cookies');
 const EventType = goog.require('goog.events.EventType');
 const GoogEvent = goog.require('goog.events.Event');
-const cookies = goog.require('goog.net.cookies');
 const dom = goog.require('goog.dom');
 const events = goog.require('goog.testing.events');
 const testSuite = goog.require('goog.testing.testSuite');
 
 const COOKIE_KEY = 'my_fabulous_cookie';
-let COOKIE_VALUES;
-
-cookies.get = (key) => COOKIE_VALUES[key];
-
-cookies.set = (key, value) => COOKIE_VALUES[key] = value;
-
-/** @suppress {missingReturn} suppression added to enable type checking */
-cookies.remove = (key, value) => {
-  delete COOKIE_VALUES[key];
-};
+const cookies = Cookies.getInstance();
 
 /** @suppress {visibility} suppression added to enable type checking */
 function newCookieEditor(cookieValue = undefined) {
@@ -48,7 +39,7 @@ function newCookieEditor(cookieValue = undefined) {
 testSuite({
   setUp() {
     dom.removeChildren(dom.getElement('test_container'));
-    COOKIE_VALUES = {};
+    cookies.remove(COOKIE_KEY);
   },
 
   testRender() {