Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the check for the existence of NFS files #3358

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

fusida
Copy link
Contributor

@fusida fusida commented Jul 26, 2023

after #3351, we find there are still many requests for nfs stats in some case.
through analysis and debugging, we found the FileExists function will cause manay unnecessary requests.
so we suggesst remove the check for the existence of NFS files and that reduced requests to nas significantly.

fix #3349
fix #3351

@k8s-ci-robot
Copy link
Collaborator

Hi @fusida. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fusida
Copy link
Contributor Author

fusida commented Jul 26, 2023

@iwankgb PTAL, thanks a lot~

fs/fs.go Outdated Show resolved Hide resolved
@iwankgb
Copy link
Collaborator

iwankgb commented Jul 28, 2023

/ok-to-test

@iwankgb iwankgb merged commit 0685c79 into google:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance degradation of NFS after upgrading Kubernetes from 1.20 to 1.22
3 participants