-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to AWS Go SDK v2 #3201
Migrate to AWS Go SDK v2 #3201
Conversation
Hi @skitt. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@skitt landing this in cadvisor will make it hard to integrate a new version of cadvisor in kubernetes. Unless of course we have a draft PR in k8s that can do the same change in dependency in kubernetes as well. (we don't want to have 2 versions of a cloud provider library/dependency in k8s). |
Ah yes, good point… I’ll look into the k8s situation and report back. |
@dims now that the AWS dependency is gone from K8s, this should be OK; is it? |
yep! |
@skitt, you may need to merge |
777d9f1
to
f3795fe
Compare
You need to run |
I do indeed, in |
Version 2 of the SDK splits features across different Go modules. See https://aws.github.io/aws-sdk-go-v2/docs/migrating/ for the migration guide. Signed-off-by: Stephen Kitt <[email protected]>
/ok-to-test |
Version 2 of the SDK splits features across different Go modules. See
https://aws.github.io/aws-sdk-go-v2/docs/migrating/ for the migration
guide.
Signed-off-by: Stephen Kitt [email protected]