-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.39] Cgroup v2 fixes backport #2879
Conversation
read the memory stats from the specified cgroup instead of looking the values up in the ancestor cgroups. Signed-off-by: Giuseppe Scrivano <[email protected]> (cherry picked from commit cf79551) Signed-off-by: Kir Kolyshkin <[email protected]>
when the "max" value is found handle it as math.MaxUint64. Signed-off-by: Giuseppe Scrivano <[email protected]> (cherry picked from commit 7bd9ea7) Signed-off-by: Kir Kolyshkin <[email protected]>
read quota and limit from cpu.max, and convert cpu.weight to the range expected with cgroup v1. Signed-off-by: Giuseppe Scrivano <[email protected]> (cherry picked from commit 56ced55) Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]> (cherry picked from commit 5bffc55) Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]> (cherry picked from commit 70b339d) Signed-off-by: Kir Kolyshkin <[email protected]>
Hi @kolyshkin. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
/ok-to-test |
@googlebot I consent. |
all green! |
@bobbypage PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a backport of
to release-0.39 branch.
Fixes: #2878