Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting #2750, 2755 and #2770 to 0.37 #2816

Closed
wants to merge 6 commits into from
Closed

Backporting #2750, 2755 and #2770 to 0.37 #2816

wants to merge 6 commits into from
+371 −94

Conversation

iwankgb
Copy link
Collaborator

@iwankgb iwankgb commented Mar 1, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes label Mar 1, 2021
pkagrawal and others added 6 commits March 1, 2021 18:43
@pkagrawal @iwankgb
Fix race between OnDemandHousekeeping and housekeepingTick
43afd1e 
This fixes the data race between the functions which could be running
in different goroutines.

Signed-off-by: Pradyumna Agrawal <[email protected]>
@pkagrawal @iwankgb
Fix typo in previous commit
b7761f9 
Signed-off-by: Pradyumna Agrawal <[email protected]>
@pkagrawal @iwankgb
cd.clock.Since(statsLastUpdatedTime) -> cd.clock.Since(cd.statsLastUp…
d5b2800 
…datedTime)

Signed-off-by: Pradyumna Agrawal <[email protected]>
@pkagrawal @iwankgb
add a test case
9a40ef6 
Signed-off-by: Pradyumna Agrawal <[email protected]>
@iwankgb
Command may contain spaces
01657f8 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@iwankgb
Memory cgroup is not available on some systems
6a73da3 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@iwankgb iwankgb changed the title Backporting #2750 and #2770 to 0.37 Backporting #2750, 2755 and #2770 to 0.37 Mar 1, 2021
@iwankgb iwankgb force-pushed the fixes_2750_2770_0.37 branch from b366b6e to 6a73da3 Compare March 1, 2021 17:45
@google-cla
Copy link

google-cla bot commented Mar 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 1, 2021
@iwankgb
Copy link
Collaborator Author

iwankgb commented Mar 1, 2021

@pkagrawal I need your consent to backport a bugfix to 0.37 branch.

@pkagrawal
Copy link
Contributor

LGTM

@iwankgb
Copy link
Collaborator Author

iwankgb commented Mar 1, 2021

@pkagrawal I'm afraid that the bot is expecting very precise message, one of the bot's comments above.

@pkagrawal
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 1, 2021
@iwankgb
Copy link
Collaborator Author

iwankgb commented Mar 2, 2021

@bobbypage can you merge and release a new version, please?

@iwankgb
Copy link
Collaborator Author

iwankgb commented Mar 4, 2021

0.39 is, hopefully, just around the corner and we do not want to risk already release Kubernetes versions stability. I'm withdrawing this PR after a chat with @bobbypage.

@iwankgb iwankgb closed this Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwankgb @pkagrawal