Remove go-cmp from from cache comparison #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we remove it from go modules as well? |
katarzyna-z
force-pushed
the
kk-remove-go-cmp
branch
from
0bf2515 to
afbe43c
Compare
|
Now, go-cmp is an indirect dependency. |
katarzyna-z
force-pushed
the
kk-remove-go-cmp
branch
from
afbe43c to
a3da8bf
Compare
|
I see that integration tests failed because docker return version as "Unknown" : |
Signed-off-by: Katarzyna Kujawa <[email protected]>
katarzyna-z
force-pushed
the
kk-remove-go-cmp
branch
from
a3da8bf to
09c98f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katarzyna Kujawa [email protected]
As indicated here go-cmp should not be used in production environment because it may panic if it cannot compare the values.