Skip to content

Commit

Permalink
Merge pull request #2679 from katarzyna-z/fix-typo
Browse files Browse the repository at this point in the history
Fix typo in libipmctl
  • Loading branch information
bobbypage authored Oct 30, 2020
2 parents fe54dc8 + a85b401 commit b31c0ce
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions docs/development/build.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ For integration tests, see the [integration testing](integration_testing.md) pag
### Non-volatile Memory Support

cAdvisor can be linked against [libipmctl](https://github.com/intel/ipmctl) library that allows to gather information about Intel® Optane™ DC Persistent memory. If you want to build cAdvisor with libipmctl support you must meet following requirements:
* `libimpctl-devel` must be installed on build system.
* `libimpctl` must be installed on all systems where cAdvisor is running.
* `libipmctl-devel` must be installed on build system.
* `libipmctl` must be installed on all systems where cAdvisor is running.

Detailed information about building `libipmctl` can be found in the project's [README](https://github.com/intel/ipmctl#build). Make sure to use the most up to date released version. Functionality that relies on `libipmctl` was tested against version 02.00.00.3719 of the library.

To enable `libimpctl` support `GO_FLAGS` variable must be set:
To enable `libipmctl` support `GO_FLAGS` variable must be set:

```
$GOPATH/src/github.com/google/cadvisor $ GO_FLAGS="-tags=libipmctl,netgo" make build
Expand Down
2 changes: 1 addition & 1 deletion nvm/machine_libipmctl.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func GetInfo() (info.NVMInfo, error) {

nvmInfo := info.NVMInfo{}
if !isNVMLibInitialized {
klog.V(1).Info("libimpctl has not been initialized. NVM information will not be available")
klog.V(1).Info("libipmctl has not been initialized. NVM information will not be available")
return nvmInfo, nil
}

Expand Down
2 changes: 1 addition & 1 deletion nvm/machine_no_libipmctl.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ func GetInfo() (info.NVMInfo, error) {
// Finalize un-initializes libipmctl. See https://github.com/google/cadvisor/issues/2457.
// When libipmctl is not available it just logs that it's being called.
func Finalize() {
klog.V(4).Info("libimpctl not available, doing nothing.")
klog.V(4).Info("libipmctl not available, doing nothing.")
}

0 comments on commit b31c0ce

Please sign in to comment.