Build libpfm with rules_cc
#1922
Merged
+229
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmah42
approved these changes
Feb 10, 2025
|
@dmah42 i’m not sure what to do about the filing jobs. |
|
I'm working on those in other PRs. not your problem. |
|
@dmah42 thanks for the review! Do you know roughly when the next release will be cut? |
|
i will do one when all the CI issues are fixed i think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of
rules_foreign_ccwhich the use of causes the following issue for all Bazel users: bazelbuild/bazel#24871