Retrieve the number of online CPUs on OpenBSD and NetBSD #1916
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad0
force-pushed
the
sysinfo_openbsd_ncpu
branch
from
42d2ab4 to
3d3122c
Compare
dmah42
reviewed
Feb 4, 2025
| @@ -153,11 +153,11 @@ ValueUnion GetSysctlImp(std::string const& name) { | |||
| int mib[2]; | |||
|
|
|||
| mib[0] = CTL_HW; | |||
| if ((name == "hw.ncpu") || (name == "hw.cpuspeed")) { | |||
| if ((name == "hw.ncpuonline") || (name == "hw.cpuspeed")) { | |||
There was a problem hiding this comment.
The sysctl name is hw.ncpuonline.
There was a problem hiding this comment.
https://man.openbsd.org/sysctl.2 includes ncpufound which seems to be more predictable in some cases (from brief reading i did). i'm not an expert but i want to make sure that we're picking the right one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.