benchmark declarations can and should be const (clang-tidy)

google · Feb 11, 2025 · 56560d6 · 56560d6
1 parent a125fb6
commit 56560d6
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/include/benchmark/benchmark.h b/include/benchmark/benchmark.h
@@ -1438,10 +1438,10 @@ class Fixture : public internal::Benchmark {
 #define BENCHMARK_PRIVATE_CONCAT_NAME(BaseClass, Method) \
   BaseClass##_##Method##_Benchmark
 
-#define BENCHMARK_PRIVATE_DECLARE(n)                                 \
-  /* NOLINTNEXTLINE(misc-use-anonymous-namespace) */                 \
-  static ::benchmark::internal::Benchmark* BENCHMARK_PRIVATE_NAME(n) \
-      [[maybe_unused]]
+#define BENCHMARK_PRIVATE_DECLARE(n)                    \
+  /* NOLINTNEXTLINE(misc-use-anonymous-namespace) */    \
+  static ::benchmark::internal::Benchmark const * const \
+      BENCHMARK_PRIVATE_NAME(n) [[maybe_unused]]
 
 #define BENCHMARK(...)                                               \
   BENCHMARK_PRIVATE_DECLARE(_benchmark_) =                           \