Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load resources with url and optional version #2666

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Aug 27, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 requested a review from a team as a code owner August 27, 2024 16:42
@jingtang10 jingtang10 requested a review from MJ1998 August 27, 2024 16:42
MJ1998
MJ1998 previously requested changes Aug 27, 2024
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding version looks find but why is resourceType being removed from apis here?

Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jingtang10 jingtang10 enabled auto-merge (squash) August 28, 2024 13:39
@jingtang10 jingtang10 requested a review from MJ1998 August 28, 2024 13:43
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingtang10 jingtang10 merged commit 7f4ecd2 into google:master Aug 28, 2024
6 checks passed
@jingtang10 jingtang10 deleted the knowledge-load-resource branch August 28, 2024 14:22
ndegwamartin pushed a commit to opensrp/android-fhir that referenced this pull request Sep 10, 2024
* Load resources with url and optional version

* Add back deprecated functions for build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants