Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate knowledge repository instance in the workflow library #2629

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Jul 19, 2024

Description
Merge the two instances of knowledge repository into one in the workflow library. Also improve code readability by adding some comments.

Alternative(s) considered
NA

Type
Code health

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 enabled auto-merge (squash) July 19, 2024 13:24
Copy link
Contributor

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jingtang10 jingtang10 merged commit 3cc52bd into google:master Jul 24, 2024
5 of 6 checks passed
@jingtang10 jingtang10 deleted the workflow-repos branch July 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants