Update currentSyncJobStatus for oneTimeSync when syncJobStatus is null #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santosh-pingle
changed the title
|
@santosh-pingle tested out the implementation, it works fine on our app and solves the issue we reported. |
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Apr 29, 2024
… Knowledger
- With unmerged PR #9
- WUP PR google#2178
- WUP PR google#2511
joiskash
approved these changes
May 2, 2024
ellykits
reviewed
May 3, 2024
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
May 8, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
May 14, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511
santosh-pingle
requested review from
aditya-07,
jingtang10 and
MJ1998
as code owners
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
May 28, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511 - WUP PR google#2537
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 4, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511 - WUP PR google#2464
|
@jingtang10 anything left for this PR or can we merge it? |
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 10, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 11, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511 - WUP PR google#2537 - WUP PR google#2511
7 tasks
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 26, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511 - WUP PR google#2511
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 26, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP PR google#2511 - WUP PR google#2511 - WUP PR google#2544
jingtang10
requested changes
Jul 4, 2024
jingtang10
reviewed
Jul 4, 2024
engine/src/androidTest/java/com/google/android/fhir/sync/SyncInstrumentedTest.kt
Outdated
Show resolved
Hide resolved
|
looking into review comments. |
jingtang10
approved these changes
Jul 5, 2024
santosh-pingle
added a commit
to santosh-pingle/android-fhir
that referenced
this pull request
Jul 8, 2024
google#2511) * currentSyncJobStatus when sync state in workmanager is null. * unit tests. * update kdoc * address review comments. --------- Co-authored-by: Santosh Pingle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2472
Description
WorkManager returns null status for ENQUEUED, RUNNING, and CANCELLED states. Now, if syncJobStatus is null, CurrentSyncJobStatus is created based on the WorkInfo state. If the WorkInfo state is SUCCEEDED or FAILED, then the sync job status is fetched from the FHIR data store.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.