-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API call options to the FhirOperator for OpenSRP #2383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In generateCarePlan APIs,
can we add options for the third API as well:-
fun generateCarePlan(
planDefinitionId: String,
subject: String,
encounterId: String?,
): IBaseResource {
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperator.kt
Outdated
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperator.kt
Outdated
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperator.kt
Outdated
Show resolved
Hide resolved
Thanks @vitorpamplona for the PR. This looks necessary! Requesting to create an issue and tag it here as well! Thanks. |
The
signature is deprecated. I am not sure if we should change it at this point. |
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperator.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also create an issue (if it does not exist) and tag it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks vitor!
Head branch was pushed to by a user without write access
@jingtang10 can you enable auto-merge again here? |
* Offers additional options to evaluate measures and $apply in the FhirOperator * Adds suggestions by @MJ1998 * Adding the additional data as parameter for measure evaluate * Spotless * minor change to retrigger kokoro. * spotless
* Offers additional options to evaluate measures and $apply in the FhirOperator * Adds suggestions by @MJ1998 * Adding the additional data as parameter for measure evaluate * Spotless * minor change to retrigger kokoro. * spotless
Offers additional options to evaluate measures and plan def apply in the FhirOperator
Type
Feature
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.