Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API call options to the FhirOperator for OpenSRP #2383

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

vitorpamplona
Copy link
Collaborator

Offers additional options to evaluate measures and plan def apply in the FhirOperator

Type
Feature

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In generateCarePlan APIs,
can we add options for the third API as well:-

fun generateCarePlan(
    planDefinitionId: String,
    subject: String,
    encounterId: String?,
  ): IBaseResource {

@MJ1998
Copy link
Collaborator

MJ1998 commented Dec 21, 2023

Thanks @vitorpamplona for the PR. This looks necessary!

Requesting to create an issue and tag it here as well! Thanks.

@vitorpamplona
Copy link
Collaborator Author

The

fun generateCarePlan(
    planDefinitionId: String,
    subject: String,
    encounterId: String?,
  ): IBaseResource {

signature is deprecated. I am not sure if we should change it at this point.

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MJ1998
Copy link
Collaborator

MJ1998 commented Dec 27, 2023

Also create an issue (if it does not exist) and tag it.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks vitor!

@jingtang10 jingtang10 enabled auto-merge (squash) January 8, 2024 16:30
auto-merge was automatically disabled January 9, 2024 13:43

Head branch was pushed to by a user without write access

@vitorpamplona
Copy link
Collaborator Author

@jingtang10 can you enable auto-merge again here?

@aditya-07 aditya-07 merged commit 30a07d7 into google:master Jan 9, 2024
3 checks passed
hugomilosz pushed a commit to hugomilosz/android-fhir that referenced this pull request Jan 17, 2024
* Offers additional options to evaluate measures and $apply in the FhirOperator

* Adds suggestions by @MJ1998

* Adding the additional data as parameter for measure evaluate

* Spotless

* minor change to retrigger kokoro.

* spotless
sharon2719 pushed a commit to opensrp/android-fhir that referenced this pull request Feb 6, 2024
* Offers additional options to evaluate measures and $apply in the FhirOperator

* Adds suggestions by @MJ1998

* Adding the additional data as parameter for measure evaluate

* Spotless

* minor change to retrigger kokoro.

* spotless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants