-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support location widget to get current location #2341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
force-pushed
the
support-location-widget
branch
from
November 28, 2023 02:49
dbed0ab
to
47d3126
Compare
LZRS
force-pushed
the
support-location-widget
branch
from
January 17, 2024 07:36
47d3126
to
7ee6c49
Compare
Added a custom location-widget as contrib/locationwidget library
LZRS
force-pushed
the
support-location-widget
branch
3 times, most recently
from
January 18, 2024 13:57
1ef4ca9
to
11812a8
Compare
LZRS
force-pushed
the
support-location-widget
branch
from
January 18, 2024 14:06
11812a8
to
26fa19d
Compare
jingtang10
approved these changes
Jan 30, 2024
Can we merge this in ? @jingtang10 |
jingtang10
approved these changes
Feb 1, 2024
.../main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...roid/fhir/datacapture/contrib/views/locationwidget/LocationGpsCoordinateViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
February 1, 2024 14:56
Head branch was pushed to by a user without write access
jingtang10
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please feel free to merge once the comments below are addressed.
thanks @LZRS
...est/java/com/google/android/fhir/datacapture/contrib/views/locationwidget/ExampleUnitTest.kt
Outdated
Show resolved
Hide resolved
.../com/google/android/fhir/datacapture/contrib/views/locationwidget/ExampleInstrumentedTest.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
please go through the check list in the pr description @LZRS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #800
Description
Add a custom component, location-widget in contrib/locationwidget, to detect and pick current location coordinates to populate latitude/longitude questionnaire fields
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.