Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support location widget to get current location #2341

Merged
merged 13 commits into from
Feb 7, 2024

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented Nov 28, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #800

Description
Add a custom component, location-widget in contrib/locationwidget, to detect and pick current location coordinates to populate latitude/longitude questionnaire fields

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@LZRS LZRS force-pushed the support-location-widget branch from dbed0ab to 47d3126 Compare November 28, 2023 02:49
@LZRS LZRS force-pushed the support-location-widget branch from 47d3126 to 7ee6c49 Compare January 17, 2024 07:36
Added a custom location-widget as contrib/locationwidget library
@LZRS LZRS force-pushed the support-location-widget branch 3 times, most recently from 1ef4ca9 to 11812a8 Compare January 18, 2024 13:57
@LZRS LZRS force-pushed the support-location-widget branch from 11812a8 to 26fa19d Compare January 18, 2024 14:06
@LZRS
Copy link
Collaborator Author

LZRS commented Jan 18, 2024

Questionnaire

{
  "resourceType": "Questionnaire",
  "language": "en",
  "status": "active",
  "date": "2020-11-18T07:24:47.111Z",
  "item": [
    {
      "linkId": "location-widget",
      "type": "group",
      "text": "Location Widget",
      "extension": [
        {
          "url": "https://github.com/google/android-fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "https://github.com/google/android-fhir/questionnaire-item-control",
                "code": "location-widget"
              }
            ]
          }
        }
      ],
      "item": [
        {
          "linkId": "latitude",
          "type": "decimal",
          "required": true,
          "text": "Latitude",
          "extension": [
            {
              "url": "gps-coordinate",
              "valueString": "latitude"
            }
          ]
        },
        {
          "linkId": "longitude",
          "type": "decimal",
          "required": true,
          "text": "Longitude",
          "extension": [
            {
              "url": "gps-coordinate",
              "valueString": "longitude"
            }
          ]
        }
      ]
    }
  ]
}

@LZRS LZRS marked this pull request as ready for review January 18, 2024 14:16
@LZRS LZRS requested review from santosh-pingle and a team as code owners January 18, 2024 14:16
@LZRS LZRS requested a review from ktarasenko January 18, 2024 14:16
@f-odhiambo
Copy link
Collaborator

Can we merge this in ? @jingtang10

@jingtang10 jingtang10 enabled auto-merge (squash) February 1, 2024 13:49
auto-merge was automatically disabled February 1, 2024 14:56

Head branch was pushed to by a user without write access

@LZRS LZRS requested a review from jingtang10 February 1, 2024 15:13
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please feel free to merge once the comments below are addressed.

thanks @LZRS

@jingtang10
Copy link
Collaborator

please go through the check list in the pr description @LZRS

@aditya-07 aditya-07 merged commit 4169a8d into google:master Feb 7, 2024
5 checks passed
@LZRS LZRS deleted the support-location-widget branch February 9, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Add location mapping widget
5 participants