Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourceConsolidator #2137

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Add ResourceConsolidator #2137

merged 8 commits into from
Sep 14, 2023

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Aug 17, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2103

Description
Clear and concise code change description.

The resource consolidator would handle any post-processing that needs to be made to the database. Examples of this would be, updating the lastUpdated timestamp field, or deleting the local change from the database, or updating the resource IDs and payloads to correspond with the server’s feedback.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94 omarismail94 requested review from santosh-pingle and a team as code owners August 17, 2023 09:13
@omarismail94 omarismail94 requested a review from aditya-07 August 17, 2023 09:13
@omarismail94 omarismail94 changed the title Add ResourceConsolidator Add ResourceConsolidator and Upload Modes Aug 17, 2023
@omarismail94 omarismail94 changed the title Add ResourceConsolidator and Upload Modes Add ResourceConsolidator Sep 7, 2023
@omarismail94 omarismail94 enabled auto-merge (squash) September 14, 2023 13:51
@omarismail94 omarismail94 merged commit 0bbdeb9 into google:master Sep 14, 2023
@omarismail94 omarismail94 deleted the nap branch September 14, 2023 14:30
@jingtang10 jingtang10 linked an issue Sep 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Upload Work Manager - API refactoring Create new resources on the server using POST
3 participants