-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a LocalChangeFetcher #2135
Merged
Merged
Add a LocalChangeFetcher #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated title after discussion |
anchita-g
reviewed
Aug 30, 2023
engine/src/main/java/com/google/android/fhir/sync/upload/UploaderImpl.kt
Outdated
Show resolved
Hide resolved
anchita-g
reviewed
Sep 8, 2023
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
anchita-g
reviewed
Sep 8, 2023
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
anchita-g
reviewed
Sep 8, 2023
jingtang10
requested changes
Sep 8, 2023
engine/src/androidTest/java/com/google/android/fhir/db/impl/DatabaseImplTest.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Sep 12, 2023
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks omar - this is great.
only blocking change is in fhir engine impl. other comments optional and can create follow ups.
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Sep 14, 2023
engine/src/androidTest/java/com/google/android/fhir/db/impl/DatabaseImplTest.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Sep 14, 2023
engine/src/main/java/com/google/android/fhir/sync/upload/LocalChangeFetcher.kt
Outdated
Show resolved
Hide resolved
…ChangeFetcher.kt Co-authored-by: Jing Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2103
Description
Clear and concise code change description.
The LocalChangeFetcher is an interface introduced to streamline the process of fetching and iterating through localChanges, possibly sourced from databases, APIs, or other asynchronous sources.
The objective of the interface are:
To cater to various fetching requirements, an enum named
FetchStrategy
will be introduced. This enum will define all possible fetching strategies, such as fetching one local change at a time, or all the resources at onceAlternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.