Skip to content

make maven publish work #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

make maven publish work #2086

merged 1 commit into from
Jul 20, 2023

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Jul 20, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2072

Description
Clear and concise code change description.

Starting AGP 8.0, automatic component creation is disabled, meaning we need to explicitly configure our publication variant: https://developer.android.com/build/publish-library/configure-pub-variants

Tested:
Ran ./gradlew publishToMavenLocal and ./gradlew publishReleasePublicationToCIRepository and they both now work again :)

Content of command:
image

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94 omarismail94 requested review from a team and santosh-pingle as code owners July 20, 2023 14:45
@omarismail94 omarismail94 requested a review from aditya-07 July 20, 2023 14:45
@jingtang10 jingtang10 enabled auto-merge (squash) July 20, 2023 14:50
@jingtang10 jingtang10 merged commit a887cd7 into google:master Jul 20, 2023
@omarismail94 omarismail94 deleted the mawin branch July 20, 2023 17:26
MJ1998 pushed a commit to MJ1998/android-fhir that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Enforce usage of Java 11 when compiling
3 participants