Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix engine and knowledge library versions in workflow and testing #2085

Merged
merged 14 commits into from
Jul 25, 2023

Conversation

divyaramnath-13
Copy link
Contributor

@divyaramnath-13 divyaramnath-13 commented Jul 20, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Fix engine and knowledge library versions in workflow and testing

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@divyaramnath-13 divyaramnath-13 requested review from a team and santosh-pingle as code owners July 20, 2023 10:46
@divyaramnath-13 divyaramnath-13 marked this pull request as draft July 20, 2023 10:47
@divyaramnath-13 divyaramnath-13 marked this pull request as ready for review July 24, 2023 10:17
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyaramnath-13 thanks for this - great job!

just one question actually - please address or leave reasoning. either way happy for this to be merged.

testing/build.gradle.kts Show resolved Hide resolved
@jingtang10 jingtang10 merged commit aa97c37 into google:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants