DialogSelectViewHolderFactory update flow replay count to zero.

[santosh-pingle]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2055

Description
QuestionnaireItemDialogSelectViewModel is created as a shared ViewModel by activityViewModel() to share data between DialogSelectViewHolderFactory and OptionSelectDialogFragment.
The ViewModel stays in memory after both fragments are destroyed as scope is activity.
When the view (DialogSelectViewHolderFactory) is launched again, QuestionnaireItemDialogSelectViewModel emits the previously buffered state because of replay value which is 1.

Alternative(s) considered
Another approach is to clear the ViewModel, but calling viewModelStore.clear() will clear all ViewModels.

Type
Choose one: Bug fix.

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[jingtang10]

@kevinmost can you take a look at this please?

[jingtang10]

Thanks @santosh-pingle for this fix!

[jingtang10]

@kevinmost can you take a look at this please?

discussed with kevin - he said this makes sense.