Ig manager integration with the workflow library #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktarasenko
force-pushed
the
ig-manager-integ
branch
from
69ca12b to
538eb47
Compare
ktarasenko
commented
Feb 22, 2023
ktarasenko
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
kevinmost,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
jingtang10
requested changes
Mar 8, 2023
workflow/src/main/java/com/google/android/fhir/workflow/FhirEngineDal.kt
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirEngineDal.kt
Outdated
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperatorBuilder.kt
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperatorBuilder.kt
Outdated
Show resolved
Hide resolved
ktarasenko
force-pushed
the
ig-manager-integ
branch
from
538eb47 to
5bb932e
Compare
…r-integ # Conflicts: # workflow/src/main/java/com/google/android/fhir/workflow/FhirOperatorBuilder.kt
ktarasenko
force-pushed
the
ig-manager-integ
branch
from
f3d109b to
3ecec13
Compare
ktarasenko
force-pushed
the
ig-manager-integ
branch
from
82c0e8e to
f22fe8f
Compare
|
@ktarasenko The tests are failing running |
jingtang10
requested changes
Mar 24, 2023
workflow/src/test/java/com/google/android/fhir/workflow/FhirOperatorTest.kt
Outdated
Show resolved
Hide resolved
implementationguide/src/main/java/com/google/android/fhir/implementationguide/IgManager.kt
Outdated
Show resolved
Hide resolved
implementationguide/src/main/java/com/google/android/fhir/implementationguide/IgManager.kt
Outdated
Show resolved
Hide resolved
implementationguide/src/main/java/com/google/android/fhir/implementationguide/IgManager.kt
Outdated
Show resolved
Hide resolved
implementationguide/src/main/java/com/google/android/fhir/implementationguide/IgManager.kt
Outdated
Show resolved
Hide resolved
implementationguide/src/main/java/com/google/android/fhir/implementationguide/IgManager.kt
Outdated
Show resolved
Hide resolved
implementationguide/src/main/java/com/google/android/fhir/implementationguide/IgManager.kt
Outdated
Show resolved
Hide resolved
implementationguide/src/main/java/com/google/android/fhir/implementationguide/IgManager.kt
Outdated
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirEngineDal.kt
Outdated
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperator.kt
Outdated
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperatorBuilder.kt
Show resolved
Hide resolved
jingtang10
approved these changes
Apr 4, 2023
… of the "default ig" and use `null` instead
ktarasenko
force-pushed
the
ig-manager-integ
branch
from
23f1a4e to
7416f3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Contributes to #1729
Description
Integrate [IgManager] into [FhirOperator].
Highlights:
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.