Pass original response items instead of copy to getEnabledResponses #1787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1776
Description
In
getQuestionnaireResponse
we are passing the questionnaire response items of the copy of the quesitonnaireResponse and in the EnablementEvaluator we create thequestionnaireResponseItemPreOrderList
andquestionnaireResponseItemParentMap
from the questionnaireResponse. This would result in itemIndex = -1 for all indexOf search, since we are trying to search for objects in the original list whereas the list item that is being searched for is part of the copy list.The code change is to pass
[email protected]
. This will search for items in the original list and the enablementEvaluator will work as expectedAlternative(s) considered
No
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.