Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Cache ModelResolver and use cached FhirContext #1753

Merged

Conversation

vitorpamplona
Copy link
Collaborator

ModelResolver is one of the slowest objects to load: 5.12 seconds in debug.

This PR

  1. Makes R4FhirModelResolver a singleton.
  2. Makes use of a cached context for increased performance.

The default constructor R4FhirModelResolver() constructor recreates the FhirContext.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

…or R4FhirModelResolver() constructor recreates the FhirContext.
@jingtang10 jingtang10 enabled auto-merge (squash) February 20, 2023 20:24
@vitorpamplona vitorpamplona requested a review from jingtang10 March 6, 2023 16:41
@jingtang10 jingtang10 merged commit 9ee9c81 into google:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants