Refactor Sync API #1578
Merged
Refactor Sync API #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maimoonak FYI - the current sync APIs need some simplification. please see this pr. i think the main issue is that the sync job shouldn't be exposed to the client and information should be exposed as flow. we can discuss in more detail if you like. @joiskash and @PallaviGanorkar fyi too discussed this with @aditya-07 |
aditya-07
reviewed
Sep 7, 2022
jingtang10
requested review from
deepankarb,
jjtswan,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
aditya-07
reviewed
Oct 7, 2022
aditya-07
reviewed
Nov 4, 2022
demo/src/main/java/com/google/android/fhir/demo/MainActivity.kt
Outdated
Show resolved
Hide resolved
demo/src/main/java/com/google/android/fhir/demo/PatientListFragment.kt
Outdated
Show resolved
Hide resolved
demo/src/main/java/com/google/android/fhir/demo/PatientListFragment.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/SyncJobStatus.kt
Outdated
Show resolved
Hide resolved
ktarasenko
pushed a commit
to ktarasenko/android-fhir
that referenced
this pull request
Nov 19, 2022
* Remove the `SyncJob` interface * Remove the `SyncJob` interface * Run spotless * Use worker's class name as the unique identifier for the job * Refactor result API * Run spotless apply * Add API to retrieve last updated timestamp * Uncomment accidentally commented code * Add documentation to sync job status * Use KEEP policy for periodic sync * Wrap one time sync in a function * Fix application context * Run spotless Co-authored-by: aditya-07 <[email protected]>
ktarasenko
pushed a commit
to ktarasenko/android-fhir
that referenced
this pull request
Nov 19, 2022
* Remove the `SyncJob` interface * Remove the `SyncJob` interface * Run spotless * Use worker's class name as the unique identifier for the job * Refactor result API * Run spotless apply * Add API to retrieve last updated timestamp * Uncomment accidentally commented code * Add documentation to sync job status * Use KEEP policy for periodic sync * Wrap one time sync in a function * Fix application context * Run spotless Co-authored-by: aditya-07 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
FhirPeriodicSyncWorkertoFhirSyncWorkersince it is now used by both periodic sync and one time syncSyncJobAPI and its implementationSyncJobImpsince it is not the right level of abstraction we should be providing to the application.StateFlowto return the worker status for both one time and periodic work.StatetoSyncJobStatusFuture work:
Alternative(s) considered
@aditya-07 and I have discussed the current approach and concluded the current API isn't easy to use by the client
Type
Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.