Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

update apple-touch-icon guidance #7582

Merged
merged 3 commits into from
May 8, 2019
Merged

update apple-touch-icon guidance #7582

merged 3 commits into from
May 8, 2019

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented May 6, 2019

What's changed, or what was fixed?

  • Updated the guidance on apple-touch-icon
  • removed [sizes] examples. clearer reccs on precomposed, the image size, etc.

See https://webhint.io/docs/user-guide/hints/hint-apple-touch-icons/ to verify these recommendations.

Target Live Date: asap

  • This has been reviewed and approved by @kaycebasques
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label.
  • I've staged the site and manually verified that my content displays correctly.

CC: @petele

@paulirish paulirish requested review from petele and kaycebasques May 8, 2019 01:42
@paulirish
Copy link
Member Author

A brand new PWA audit in lighthouse links to this page.. and a number of PWAs are failing on it.. So i'm eager to get these changes live. :)

@WebFundBot
Copy link

Whoops!

There were 5 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

WARNINGS
src/content/en/fundamentals/design-and-ux/browser-customization/index.md#L19 - Common typo found: 'webpage' Should it be 'web page'? See: https://developers.google.com/style/word-list#web_page
src/content/en/fundamentals/design-and-ux/browser-customization/index.md#L14 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/browser-customization/index.md#L19 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/browser-customization/index.md#L137 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/browser-customization/index.md#L143 - Line must be at most 100 characters

@kaycebasques
Copy link
Contributor

Let's have a looksie

@kaycebasques kaycebasques merged commit 803b9bb into master May 8, 2019
@kaycebasques kaycebasques deleted the paulirish-patch-1 branch May 8, 2019 01:52
@WebFundBot
Copy link

🎉 This has been pushed live to https://developers.google.com/web/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants