Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support content uri (e.q. content://xxx) #465

Merged
merged 1 commit into from
May 18, 2015

Conversation

Ood-Tsen
Copy link
Contributor

In android, content-uri is widely used.
For example, "content://download/" , "content://media/external/video" and so on.

We can query the file descriptor from content resolver and create the input stream from it.

@ojw28
Copy link
Contributor

ojw28 commented May 18, 2015

Thanks. We'll push a change shortly that makes this usable via DefaultUriDataSource as well (DefaultUriDataSource will take http/https/asset/content Uris and delegate to the correct more-specific DataSource implementation).

ojw28 added a commit that referenced this pull request May 18, 2015
support content uri (e.q. content://xxx)
@ojw28 ojw28 merged commit 8205256 into google:dev May 18, 2015
@Ood-Tsen
Copy link
Contributor Author

It's great !!

Can we consider the empty scheme case ?(e.g. like #467)

/storage/emulated/0/Android/data/com.getvictorious.staging.eatyourkimchi/files/DCIM/Video/Video-20150518_142803.mp4

@Ood-Tsen Ood-Tsen deleted the contentDataSource branch May 19, 2015 07:58
@ojw28
Copy link
Contributor

ojw28 commented May 19, 2015

Yeah, I think we should probably assume file:// if the scheme is empty.

@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants