Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiximaextension #4153

Closed
wants to merge 2 commits into from
Closed

Conversation

Veeyikpong
Copy link

Set the imaAdState back to IMA_AD_STATE_PLAYING when the ads resumed, This can prevent some playback issue when pause and resume the player.
I encountered this issue when i have three 10 seconds ads and one 15 seconds ads in my playlist. When i pause the 15 seconds ads and resume it, the remaining ads will be skipped.
This commit can fix the issue.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Veeyikpong
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@andrewlewis
Copy link
Collaborator

As discussed in #4143, this fix didn't work when I tried it. A recent IMA server-side fix may also address this issue, so I will close this for now. We can reopen it if this turns out to be the right way to work around the issue.

@google google locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants