Simplify tracing computations, part #1. #4138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/568323122
branch
from
c560e47 to
0f2b982
Compare
These three CLs are stacked on top of each other and they make the tracing logic more complex. Rolling these CLs back will simplify tracing logic and improve static analysis and lint. The stacktraces will have more depth, but hopefully they will also be more clear as well. 1. Revert b82dd1a - Refactors the computation wrapper to allow for non-tracing strategies. 2. Revert 827f21e - Remove the remaining TFF stack frames from tracing errors. 4. Revert 1406a91 - Invert control of some tracing functions to shorten stacktraces. PiperOrigin-RevId: 568323122
copybara-service
bot
force-pushed
the
cl/568323122
branch
from
0f2b982 to
8466a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify tracing computations, part #1.
These three CLs are stacked on top of each other and they make the tracing logic more complex. Rolling these CLs back will simplify tracing logic and improve static analysis and lint. The stacktraces will have more depth, but hopefully they will also be more clear as well.