fix: add runs-on to README.md example #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @lbarthon - in order to accept your contribution, we need you to sign the Google CLA. |
This is needed in order for this example to "work". The runner that needs to be picked is specified above, but it's still handy if we can simply copy / paste from the README.
lbarthon
force-pushed
the
lbarthon/add-runs-on
branch
from
b2e0f4c to
953a229
Compare
|
@sethvargo - Signed and force-pushed for builds to re-run! |
|
Thanks! |
Merged
google-github-actions-bot
added a commit
that referenced
this pull request
Feb 1, 2025
## What's Changed * Update TROUBLESHOOTING.md by @sethvargo in #457 * fix: add runs-on to README.md example by @lbarthon in #460 * security: bump undici from 5.28.4 to 5.28.5 in the npm_and_yarn group by @dependabot in #463 * Update deps by @sethvargo in #466 ## New Contributors * @lbarthon made their first contribution in #460 **Full Changelog**: v2.1.7...v2.1.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order for this example to "work". The runner that needs to be picked is specified above, but it's still handy if we can simply copy / paste from the README.