Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple bugs where not all params are passed through to the request #103

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

hsubox76
Copy link
Collaborator

Fixed bugs where

  • RequestOptions was not passed to countTokens and embedContent
  • generationConfig and safetySettings were not passed through startChat to ChatSession.

Fixes #101
Fixes #98

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 6724e42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@google/generative-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 16, 2024 01:27
@hsubox76 hsubox76 requested a review from lahirumaramba April 16, 2024 16:12
Copy link
Collaborator

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants