-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New docs polish #211
New docs polish #211
Conversation
|
||
pygments_style = 'sphinx' | ||
pygments_style = 'algol_nu' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to get a slightly modified version of this with just a bit more contrast in the palette.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! the actor model discussion always comes up when introducing people to the project, its really clear and to the point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @goodboy, nice docs polish! I have some small comments but nothing outstanding, it's looking solid for me!
Also, great theme from https://sphinx-book-theme.readthedocs.io/, seems to have a clean visual style but still very robust (with the margin elements, code blocks, TOC navigation...) 😃
docs/README.rst
Outdated
the problem of *unbounded non-determinism* (which was the whole point | ||
for creation of the model in the first place). | ||
|
||
Again, ``tractor`` does seem to adhere to the base requirements of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the Again
& does seem to
parts and replace them with a more "certain / to the point"? statement:
tractor
aims to adhere to the base requirements of an "actor model".
docs/README.rst
Outdated
From the author's mouth, **the only thing required** is `adherance to`_ | ||
the `3 axioms`_, *and that's it*. | ||
|
||
To get more fired up on the matter, please read these issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is minor, but I feel this section might read more fluidly if these "read more" lines were moved next to the If you want do debate this further
paragraph, so that the reader goes through:
- Context (
From the author's mouth...
) - "Flaws" in existing systems (
many "actor systems"...
) - What
tractor
brings to the table (tractor
aims to...) - Further reading and discussion (`If you want do debate...)
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup sounds good.
Yah 😎, it needs a bit more tweaking and possibly a PR into the theme to get it exactly where I'd like it but it's much closer to what i've been imagining. I will for sure address your quiffs with the actors rant section 😂 |
Think I'm just gonna land this and get a feel for this new docs theme going.. |
README bump for #210 as well a new docs theme which still has some stuff to work through (re: #157 (comment)).
I'd like to get our docs looking super polished before next release with a proper tutorial set as per #157.
Please feel free to (in particular) criticize the heck out of the readme update.