Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs polish #211

Merged
merged 5 commits into from
Jun 14, 2021
Merged

New docs polish #211

merged 5 commits into from
Jun 14, 2021

Conversation

goodboy
Copy link
Owner

@goodboy goodboy commented May 31, 2021

README bump for #210 as well a new docs theme which still has some stuff to work through (re: #157 (comment)).

I'd like to get our docs looking super polished before next release with a proper tutorial set as per #157.

Please feel free to (in particular) criticize the heck out of the readme update.


pygments_style = 'sphinx'
pygments_style = 'algol_nu'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to get a slightly modified version of this with just a bit more contrast in the palette.

Copy link
Collaborator

@guilledk guilledk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! the actor model discussion always comes up when introducing people to the project, its really clear and to the point.

Copy link
Collaborator

@chrizzFTD chrizzFTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goodboy, nice docs polish! I have some small comments but nothing outstanding, it's looking solid for me!
Also, great theme from https://sphinx-book-theme.readthedocs.io/, seems to have a clean visual style but still very robust (with the margin elements, code blocks, TOC navigation...) 😃

docs/README.rst Outdated
the problem of *unbounded non-determinism* (which was the whole point
for creation of the model in the first place).

Again, ``tractor`` does seem to adhere to the base requirements of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the Again & does seem to parts and replace them with a more "certain / to the point"? statement:

tractor aims to adhere to the base requirements of an "actor model".

docs/README.rst Outdated
From the author's mouth, **the only thing required** is `adherance to`_
the `3 axioms`_, *and that's it*.

To get more fired up on the matter, please read these issues:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is minor, but I feel this section might read more fluidly if these "read more" lines were moved next to the If you want do debate this further paragraph, so that the reader goes through:

  • Context (From the author's mouth...)
  • "Flaws" in existing systems (many "actor systems"...)
  • What tractor brings to the table (tractor aims to...)
  • Further reading and discussion (`If you want do debate...)

What do you think?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup sounds good.

@goodboy
Copy link
Owner Author

goodboy commented Jun 1, 2021

Also, great theme from https://sphinx-book-theme.readthedocs.io/, seems to have a clean visual style but still very robust (with the margin elements, code blocks, TOC navigation...) smiley

Yah 😎, it needs a bit more tweaking and possibly a PR into the theme to get it exactly where I'd like it but it's much closer to what i've been imagining.

I will for sure address your quiffs with the actors rant section 😂

@goodboy goodboy marked this pull request as ready for review June 14, 2021 10:41
@goodboy
Copy link
Owner Author

goodboy commented Jun 14, 2021

Think I'm just gonna land this and get a feel for this new docs theme going..

@goodboy goodboy merged commit e983022 into master Jun 14, 2021
@goodboy goodboy deleted the new_docs_polish branch June 14, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants