Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve error when adding the stop block to the workspace #56

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: resolve error when adding the stop block to the workspace #56

merged 1 commit into from
May 6, 2024

Conversation

gonfunko
Copy link
Owner

@gonfunko gonfunko commented May 6, 2024

This PR resolves an issue that prevented dragging out the stop block.

@BeksOmega
Copy link
Collaborator

I am slightly confuzzled by this, what was the error this fixes?

@gonfunko
Copy link
Owner Author

gonfunko commented May 6, 2024

You'd get an infinite loop when you drag it out, IIRC you suggested this fix to me a while back.

BeksOmega
BeksOmega approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok I see. Yeah this looks legit! The dropdown value should always be serialized so there's no reason to have the mutator. We should definitely test the deserialization of these blocks before shipping though.

@gonfunko gonfunko merged commit f3e059c into modern-blockly May 6, 2024
1 check passed
@gonfunko gonfunko deleted the stop-block branch May 6, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonfunko @BeksOmega