fix: fix bug where user would be prompted to confirm deletion of variable blocks in the flyout #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able blocks in the flyout
BeksOmega
approved these changes
Aug 14, 2024
|
I realized this is actually present in core (v12, a regression from v11), so going to try fixing it there. |
|
Reverting in favor of fixing upstream with google/blockly#8529. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where deleting a variable via the "Delete the 'X' variable" menu item in the variable dropdown field of a block in the flyout would ask the user to confirm the deletion of the 5 other uses of that variable, ie the other variable-related blocks in the flyout. Now, the user will only be prompted to confirm the deletion of uses of the variable in the main workspace.